Add extra step for DDC library bundle format #2615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart-lang/sdk@6127d6c adds an extra check to avoid emitting extra runtime checks if the hot reload generation hasn't changed. One of the breakpoint tests relies on the JS location of the Dart code being the location right before the function call, but that needs to be updated to step past that extra check.
|
This should be fixed in the compiler instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk@6127d6c adds an extra check to avoid emitting extra runtime checks if the hot reload generation hasn't changed. One of the breakpoint tests relies on the JS location of the Dart code being the location right before the function call, but that needs to be updated to step past that extra check.